Recommended Addon

[Morac]

Maintainer: Morac
Creator: Michael Kraft

Ext. Version: 1.9.4
Release date: 0000-00-00
Description: Counts the number of open tabs
Extension is compatible to: ( 2.0a1 - 2.13a1) ( 8.0 - 9.0.0.*) ( 0.8 - 3.*.*) ( 2.0 - 16.0a1)

Included locales: cs da de el en-US es-ES fr he he-IL hr hu ja mk nl pl pt-BR pt-PT ru sr sv-SE tr uk zh-CN zh-TW

View on WTS -- Download the extension

This post has been edited by Morac: Jun 11 2012, 15:15

[Cashman]

Hungarian (hu-HU) locale added, tested and finally set as released.

[teo]

@Michael
I registered as Polish translator, but when checked my translation I saw ugly options dialog. Screen attached in image 1. I made some changes in the 'options.xul' file and result you can see on image 2. I added also localized extension description, added and removed some strings from 'install.rdf' Who now is using Firefox version less 1.5?

Attached File(s)

 tc1.jpg ( 34.25K ) Number of downloads: 11
 tc2.jpg ( 27.41K ) Number of downloads: 16
 tabcounter_1.5T.xpi ( 7.28K ) Number of downloads: 5

 

[Tsprajna]

@Goofy
Hi,
I found Tab Counter useful and that zh-TW has no translator yet so I add myself as Traditional Chinese locale translator.
But after I had finished the translation and had saved it, everything was not saved. Also, an upload of locale file is not possible.
I saw another translator complained same problem.
What happened to WTS?

EDIT: Problem disappeared today. locale updated.

[Tsprajna]

Hi Morac,

Questions about testing strings {&open_tab_count, &open_tabs} of Ver. 1.5:
1) How to see the title string in both FF2 and FF3?
2) The latter (tooltip text) seems not used by FF 2.0.0.16 since you changed to non-button? It can be seen by FF 3.0.1 portable.

Edit:
OK- 1) is see on both FF2 & FF3 when customizing tool bar. It's the title of the icon/button.
NOK- 2) still show nothing on FF2 when mouse over the tool bar icon.

[chuzo]

Spanish (es-ES) locale available in the WTS

Spanish (Spain) / es-ES

by Proyecto Nave

Here is also Spanish locale for AMO page

Greetings from Spain

Attached File(s)

 tabcounter_AMO_es_ES.txt ( 592bytes ) Number of downloads: 2

 

[Morac]

@Michael
I registered as Polish translator, but when checked my translation I saw ugly options dialog. Screen attached in image 1. I made some changes in the 'options.xul' file and result you can see on image 2. I added also localized extension description, added and removed some strings from 'install.rdf' Who now is using Firefox version less 1.5?

I incorporated the changes you made related to the layout of the options menu, though I left the script in the options.xul file. I know it's messy, but I don't want the tabcount script running when the options window is open and I don't feel like creating a brand new .js file just for those two functions. I had already changed the labels to text-link types in my private version, so I didn't need the style you added to them.

I also removed the translation stuff from the install.rdf like you recommended and bumped up the minversion for Flock and Firefox to prevent people from installing it in Mozilla versions lower than 2.0. You're right in that it's doubtful that anyone is still using Firefox 1.5, though inevitably someone will email me and complain that it doesn't work in Firefox 1.5.

[Morac]

Hi Morac,

Questions about testing strings {&open_tab_count, &open_tabs} of Ver. 1.5:
1) How to see the title string in both FF2 and FF3?
2) The latter (tooltip text) seems not used by FF 2.0.0.16 since you changed to non-button? It can be seen by FF 3.0.1 portable.

Edit:
OK- 1) is see on both FF2 & FF3 when customizing tool bar. It's the title of the icon/button.
NOK- 2) still show nothing on FF2 when mouse over the tool bar icon.

In Firefox 2.0.0.16, the tooltip won't show up when you first mouse over it, but if you blur and then refocus the browser window (click outside it and then on it), then the tooltip works. So this is probably a bug in Firefox 2.0.0.x.

I managed to work around it though. See my attached version which contains the latest translation files as well as the changes recommened by teo above.

edit - re-uploaded add-on since I uploaded the wrong version.

[teo]

Hi Morac,
I tested you new 'options.xul' file code and result you can see on the attached image. You used

CODE

<label value="&cssInfo.label;" maxwidth="235"/>

In this case text isn't wrapped. See mine code

CODE

<label id="info" maxwidth="235">&cssInfo.label;</label>

In this case text is wrapped.

Another one thing - in the 'prefwindow' each 'prefpane have to have ID, even if one 'prefpane' exist.
About text-link class. Maybe will be good if you add 'text-decoration: none;' class?
IMHO this string should be 'Change Items Property (click label for CSS info):'
What about localize extension description? You not include it in your 1.6 version.

Attached File(s)

 tc4.jpg ( 32.28K ) Number of downloads: 12

 

[Morac]

Hi Morac,
I tested you new 'options.xul' file code and result you can see on the attached image. You used

CODE

<label value="&cssInfo.label;" maxwidth="235"/>

In this case text isn't wrapped. See mine code

CODE

<label id="info" maxwidth="235">&cssInfo.label;</label>

In this case text is wrapped.

Fixed this.

Another one thing - in the 'prefwindow' each 'prefpane have to have ID, even if one 'prefpane' exist.
About text-link class. Maybe will be good if you add 'text-decoration: none;' class?
What about localize extension description? You not include it in your 1.6 version.

I'm not sure if a prefPane really needs an ID since it works without one, but I added one.
I used the text-link class based on the comments from the Mozilla reviewer when he accepted my 1.5 version. To tell you the truth, I thought the underlining was ugly myself, but kept the class. I like it better without underlining so I'll use the 'text-decoration:none;' style.

As for localized extension descriptions. I kind of forgot to add it, mainly because I don' have a properties file and was trying to get around having to include one. Firefox 3.0 sort of depreciated that whole method anyway and the localized description is now in the install.rdf file anyway. I guess I should add the localized description though. I want to get my new release out pretty much ASAP since the current release is somewhat broken for Mac/Linux and I'm getting complaints that the text is not centered, so I'll add the descripton for the next version.

[teo]

I left the script in the options.xul file. I know it's messy, but I don't want the tabcount script running when the options window is open and I don't feel like creating a brand new .js file just for those two functions.

You can move JS code to the separate file (as I made) and insert

CODE

<script type="application/x-javascript" src="chrome://tabcounter/content/options.js"/>

inside 'prefpane'.

[Morac]

You can move JS code to the separate file (as I made) and insert

CODE

<script type="application/x-javascript" src="chrome://tabcounter/content/options.js"/>

inside 'prefpane'.

I suppose I could, but there's no real benefit from doing so.

Also I'm running into problems with the options.xul changed I pulled in. If the text wraps too many times, the bottom of the window gets cut off. I had the same problem with my Session Manager options window so I pulled in the work-around I used for that and all is well.

I think I'm going to just upload the latest version to WTS to get things rolling.

[teo]

Also I'm running into problems with the options.xul changed I pulled in. If the text wraps too many times, the bottom of the window gets cut off. I had the same problem with my Session Manager options window so I pulled in the work-around I used for that and all is well.

This is why I used in the mine 'options.xul ' file <separator/> on end of 'prefpane'. Prefwindow with many prefpanes must be wrote very carefully and each box should have ID. Each prefpane inherit parameters from another. Good solution for options dialog based on prefwnidow with many prefpanes is method used for Firefox options window. In this method each prefpane is in the separate file and not inherit width and height form another prefpanes.

[Morac]

This is why I used in the mine 'options.xul ' file <separator/> on end of 'prefpane'. Prefwindow with many prefpanes must be wrote very carefully and each box should have ID. Each prefpane inherit parameters from another. Good solution for options dialog based on prefwnidow with many prefpanes is method used for Firefox options window. In this method each prefpane is in the separate file and not inherit width and height form another prefpanes.

I don't like artificially sizing windows to take into account what a translator may or may not do. For example if the translator translates the "info" label into 3 lines of text then the window will be cut off on the bottom even with the added <separator/>. I could then throw in several more <separator/> elements just in case, but at some point you want your window to be fool-proof and not have to tweak it if a translator does something unexpected. Not only that but when you add <separator/> elements it increases the height of the window when it is not normally needed.

From past experience I've found that by giving each label and description element a specific height, and then calling the built-in sizeToContent method, the window will size itself correctly. In this case in the window.onload function I added the following:

CODE

   var elem = document.getElementById("info");
   elem.style.height=document.defaultView.getComputedStyle(elem, null).getPropertyValue("height");
   sizeToContent;

What this does is calculate the implicit height of the label and explicitly define the label's height to that value. The window will then display correctly no matter how many lines the "info" label is.

This whole thing is a major annoyance since this needs to be done on any text element that may contained wrapped text. It really shouldn't be necessary so I decided to file a bug with Mozilla about the height issue when wrapping text.

[teo]

@Morac
Fine! Very good solution!
I tested latest version and have some remarks.
1. You made little mistake in the 'tabcounter.js' file. Your code:

CODE

pref("extensions.tabcounter@morac.description", "chrome://sessionmanager/locale/sessionmanager.properties");

Should be:

CODE

pref("extensions.tabcounter@morac.description", "chrome://tabcounter/locale/tabcounter.properties");

2. In the 'options.xul' file you used 'size="10" attribute. This attribute determines the number of characters that can be displayed in the textbox. IMHO this attribute is redundant.
3. Prefwindow also have to have ID.

[Morac]

@Morac
Fine! Very good solution!
I tested latest version and have some remarks.
1. You made little mistake in the 'tabcounter.js' file. Your code:

CODE

pref("[email="extensions.tabcounter@morac.description"]extensions.tabcounter@morac.description[/email]", "chrome://sessionmanager/locale/sessionmanager.properties");

Should be:

CODE

pref("[email="extensions.tabcounter@morac.description"]extensions.tabcounter@morac.description[/email]", "chrome://tabcounter/locale/tabcounter.properties");

2. In the 'options.xul' file you used 'size="10" attribute. This attribute determines the number of characters that can be displayed in the textbox. IMHO this attribute is redundant.
3. Prefwindow also have to have ID.

1. Stupid copy and paste mistake. Thanks for pointing that out. I'll fix it now.
2. I agree, probably not needed any more so I removed it.
3. This technically isn't true. The ID attribute is optional for all XUL elements. The only requirement is that if it is specified, it needs to be unique within the window. Since I don't reference the prefWindow in any of my scripts it technically doesn't require an ID attribute.

[Morac]

Just a FYI:

I decide to push out a corrected version of Tab Counter to AMO sans any translations. This will get the bug fixes out there now and allow time for the translations later. I made the public version 1.6.6 (since I sent some test versions of 1.6.3 to a few people) while the translated version will be 1.7.

In other words, no need to rush with the translations (even though most have finished any ways).

[Tsprajna]

Just a FYI:

I decide to push out a corrected version of Tab Counter to AMO sans any translations. This will get the bug fixes out there now and allow time for the translations later. I made the public version 1.6.6 (since I sent some test versions of 1.6.3 to a few people) while the translated version will be 1.7.

In other words, no need to rush with the translations (even though most have finished any ways).

1.7 tested and everything is OK on both FF2 and FF3.
zh-TW locale revised, re-uploaded and released.
If it's not too late, please include this version. Thanks.

p.s. Sorry, didn't know the French word "sans" until having consulted a dictionary. Please forget previous ask.

[xmoke]

zh-CN updated

[Morac]

p.s. Sorry, didn't know the French word "sans" until having consulted a dictionary. Please forget previous ask.

Sorry about that, I guess I should have just said "without". English has a tendency to borrow words from other languages and I guess I just assumed everyone would know what it means. I forgot that for most people here, English isn't their first language (let alone French).